Windows encodings fixes #4159
Merged
Windows encodings fixes #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dir.entries have filesystem encoding (ANSI in Windows). Path fragments have terminal encoding (DOS).
|
Excellent! I'm working on better non-ASCII support for Windows guests, so I'm glad to see this. Does |
|
|
|
Does this fix #3937 ? |
|
Unfortunately, it does not. I am seeing that error too. Done some debugging but no solution yet. Some really weird things in |
|
This is a good start. Thanks so much. Encodings on Windows are a nightmare. |
|
hasn't fixed |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These small fixes allow Vagrant to run under non-ASCII Windows usernames.
As it turns out, Windows uses different encodings in different parts of itself and none of them are UTF-8 :)
After these patches,
vagrant initcompletes successfully.