Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approle: do not require secret_id #522

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Feb 5, 2024

Description

secretId is no longer required for approle to support advanced use cases like machine login when bind_secret_id is false.

Closes #520

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Did not commit changes to dist/index.js (This is only done for releases by vault-action maintainers)

Community Note

  • Please vote on this pull request by adding a 👍
    reaction
    to the original pull request comment to help the community and maintainers
    prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request
    followers and do not help prioritize the request

@fairclothjm fairclothjm changed the title approle: support bind_secret_id approle: do not require secret_id Feb 5, 2024
@fairclothjm fairclothjm requested a review from a team February 5, 2024 17:48
@fairclothjm fairclothjm requested review from a team and removed request for a team February 28, 2024 14:42
@fairclothjm fairclothjm merged commit a727ce2 into main Feb 28, 2024
6 checks passed
@fairclothjm fairclothjm deleted the approle/support-bind-secret-id branch February 28, 2024 17:15
@madAndroid
Copy link

This doesn't appear to be working exactly as intended - I realise this change isn't released yet, but shouldn't I be able to use this by pointing my pipelines at @main?

Here's my action yaml:

jobs:
  create-bundle:
    name: Prepare and upload support bundle
    runs-on: my-custom-runner
    steps:

      - name: Import Secrets
        id: import-secrets
        uses: hashicorp/vault-action@main
        with:
          url: 'https://[REDACTED]'
          method: approle
          namespace: [REDACTED]
          roleId: ${{ secrets.VAULT_ROLE_ID }}
          secrets: |
            foo/data/foo username | FOO_USERNAME ;
            bar/data/bar password | BAR_PASSWORD

In my ARC runner pods, I see the correct git sha being downloaded, but it fails with:

Error: Input required and not supplied: secretId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Support for "bind_secret_id" in Approle auth method
3 participants