Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented features from GitHub Enterprise #416

Open
robbiemcmichael opened this issue Dec 3, 2019 · 2 comments
Open

Undocumented features from GitHub Enterprise #416

robbiemcmichael opened this issue Dec 3, 2019 · 2 comments

Comments

@robbiemcmichael
Copy link
Contributor

GitHub Enterprise supports additional features which don't seem to be documented in the public API. As a concrete example, there is an ldap_dn field for teams which allows their membership to be linked to an LDAP group, but unfortunately the field isn't listed in the docs for teams.

A couple of questions to clarify the intent of this library:

  • Are you willing to support features which are only available in GitHub Enterprise or does this just complicate the library?
  • Are you willing to add support for undocumented features provided the implementation is not incompatible with github.com?
@phadej
Copy link
Contributor

phadej commented Dec 3, 2019

If the GitHub Enterprise features are documented somewhere, then I'm ok with supporting them.

EDIT: I'd expect that enterprise features are the ones which are documented well.

@robbiemcmichael
Copy link
Contributor Author

Looks like they have separate documentation for the enterprise features, e.g. the ldap_dn field is documented here. I'll raise a PR for adding support for this field so we can have a concrete example of what it looks like and have the debate there for whether it's confusing for non-enterprise users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants