Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid requests with query flags #19

Open
fierce-katie opened this issue Jun 20, 2017 · 0 comments
Open

Invalid requests with query flags #19

fierce-katie opened this issue Jun 20, 2017 · 0 comments

Comments

@fierce-katie
Copy link
Contributor

We've recently encountered a couple of issues when generating Vanilla JS code.

Firstly, when a query flag is followed by something else, the generated request looks like this:

... + '&flag'&param=' + encodeURIComponent(param) ...

Instead of:

... + '&flag' + '&param=' + encodeURIComponent(param) ...

It is related to #11 and is even mentioned in a comment there. This part is easy to fix and I can propose a PR for it.

The second issue is that query flags are always added to the request (see valid code above), the actual argument of the client function is not even checked. This one is similar to #16, but I think it's better to have a separate issue for query flags processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant