Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHCJS compilation #48

Open
NCrashed opened this issue Nov 13, 2020 · 7 comments
Open

GHCJS compilation #48

NCrashed opened this issue Nov 13, 2020 · 7 comments

Comments

@NCrashed
Copy link

If you try to compile the package with GHCJS (for instance, for generation of frontend from servant API), you will get:

error: no C compiler provided for this platform
@NCrashed
Copy link
Author

I have split package to api and backend part. hexresearch@92b6cb3

@tfc
Copy link
Contributor

tfc commented Mar 26, 2021

Hi, i could use this, too. Would you mind opening a pull request in this repo in order to upstream it?

@tfc
Copy link
Contributor

tfc commented Apr 28, 2021

@maksbotan @arianvp any way to get this in? i would also port the pull request to this repo if necessary.

@maksbotan
Copy link
Contributor

Indeed, if for some weird reason you guys use servant-multipart with GHCJS (why tho?), it should be splitted into servant-multipart-api, servant-multipart-client and servant-multipart (containing server code).

I would appreciate a draft PR that I can improve on. Basically, please make the current package a subdir of the repo and add two more packages, like servant itself does it.

@tfc
Copy link
Contributor

tfc commented Apr 28, 2021

Indeed, if for some weird reason you guys use servant-multipart with GHCJS (why tho?), it should be splitted into servant-multipart-api, servant-multipart-client and servant-multipart (containing server code).

Does anything speak against doing that (i am eager to learn)? I look at this from a perspective where i have an API which simply contains file uploads and need to generate client code for it.

I would appreciate a draft PR that I can improve on. Basically, please make the current package a subdir of the repo and add two more packages, like servant itself does it.

Makes sense.

@gdeest
Copy link

gdeest commented Apr 29, 2021

Just a quick heads-up here,

There was some discussion about merging most sub-projects, including servant-multipart, into the main servant repository (see: haskell-servant/servant#1404 ). The main reason is that the cookbooks induce a dependency loop between the various projects, and updates introduce frequent breakages.

Maybe is this a good opportunity to do so for this project ? CI is already setup for GHCJS there.

@gdeest
Copy link

gdeest commented Apr 29, 2021

For the record, I am 👍 for the split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants