Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsString UnqualComponentName instance (and other no-more-strings) #4224

Closed
phadej opened this issue Jan 11, 2017 · 4 comments
Closed

Add IsString UnqualComponentName instance (and other no-more-strings) #4224

phadej opened this issue Jan 11, 2017 · 4 comments
Milestone
2.0

Comments

@phadej
Copy link
Collaborator

phadej commented Jan 11, 2017 •
edited by 23Skidoo
Loading

What it says on the tin.
@phadej phadej added this to the 2.0 milestone Jan 11, 2017
@ezyang ezyang changed the title Add FromString UnqualComponentName instance (and other no-more-strings) Add IsString UnqualComponentName instance (and other no-more-strings) Jan 11, 2017
@bgamari
Copy link
Contributor

bgamari commented Jan 12, 2017

Indeed, I ran into this while trying to build distributive with GHC master.

@bgamari
Copy link
Contributor

bgamari commented Jan 12, 2017

To be clear, distributive's Setup.hs has the following,

rewriteFile (dir </> "Build_" ++ testName suite ++ ".hs") $ unlines ...

@bgamari
Copy link
Contributor

bgamari commented Jan 12, 2017

Ignore my comment about distributive; this was due to indiscriminate use of --allow-newer. Without --allow-newer Cabal links Setup against Cabal-1.24 as expected.

@phadej
Copy link
Collaborator Author

phadej commented Jan 12, 2017

@bgamari see: ekmett/bytes#32 I hope I'll get working Setup.hs / doctests.hsc soon (across GHC & Cabal versions, build|new-build)

This was referenced Jan 12, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@phadej @bgamari