Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haddock after new-repl #5178

Closed
llelf opened this issue Mar 2, 2018 · 4 comments
Closed

haddock after new-repl #5178

llelf opened this issue Mar 2, 2018 · 4 comments

Comments

@llelf
Copy link
Member

llelf commented Mar 2, 2018

Recently cabal started to basically do a haddock build after new-repl.
Is it intentional (or my setup is broken)? It's definitely surprising.

This is what I mean:

$ cat cabal.project
packages: .

package foo
  documentation: True

$ cabal new-repl lib:foo                        --  new-repl

⟨…⟩

Ok, six modules loaded.
Collecting type info for 6 module(s) ... 	--  ghci repl
→ :quit 					--  exit from ghci
Leaving GHCi.
Preprocessing library ⟨…⟩			--  starting haddock build!!!
Running Haddock on library ⟨…⟩
⟨…⟩

@23Skidoo
Copy link
Member

23Skidoo commented Mar 2, 2018

Likely because repl and build share the same code path. Agreed that repl shouldn't do this. Is this with 2.2 or only with master?

@alexbiehl
Copy link
Member

This might be the result of the recent c094940. Maybe we should disable haddock'ing for repl builds.

@llelf
Copy link
Member Author

llelf commented Mar 6, 2018

@23Skidoo master. But I tried 2.2, the same result.

@alexbiehl new-test too likely. It shouldn't fail because of haddock error, … or is it? Not sure.

@quasicomputational
Copy link
Contributor

I verified that I can reproduce this with 2.2, and that I can't reproduce now on master. Presumably #5226 has fixed it, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants