You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lsp changing the current directory was causing other problems and had to be removed. It's unfortunate that this is blocking the 9.0 upgrade, but it will need to be fixed on the hls plugins side. It should be a simple matter of making sure all relative paths to config files are made absolute using the workspace root
Most of the test failures in #1649 are actually caused by test expectations that include file paths:
All the tests in tests/functional/Progress.hs match for progress messages that include a file path
The code action tests match for diagnostics on a file path
Those paths need fixing because the working directory is no longer the workspace root. Alternatively, make the tests more robust by fixing those expectations to not include paths. I can send a PR tomorrow if you don't get there first.
The only remaining failure is for the test that checks that the hlint plugin honors the .hlint.yaml file, which will probably require changes in the hlint plugin itself
The code action tests are failing because they use a direct cradle with relative paths in it. This is a valid thing to do and in order to support it, we'll need to change the working directory to the cradle location in ghcide since lsp no longer does this implicitly.
This causes test failures when using the latest version of
lsp
See this PR for a demonstration of the test failures: #1894
Originally posted by @pepeiborra in #1649 (comment)
The text was updated successfully, but these errors were encountered: