Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stan plugin (enabled by default) gives obnoxious suggestions #3916

Closed
vmchale opened this issue Dec 21, 2023 · 3 comments · Fixed by #3917
Closed

stan plugin (enabled by default) gives obnoxious suggestions #3916

vmchale opened this issue Dec 21, 2023 · 3 comments · Fixed by #3917

Comments

@vmchale
Copy link

vmchale commented Dec 21, 2023

Is your enhancement request related to a problem? Please describe.

stan gives a warning on every single lazy field (!) of a data structure that one defines, with the dubious suggestion to add StrictData pragmas.

Haskell is a lazy language and the idea that lazy fields cause space leaks is confused. It is embarrassing that the official language server would behave like this out of the box!

Describe the solution you'd like

Stan suggestions should not pop up or the default options should disable the warning about defining non-strict data structures.

Additional context

image
@fendor
Copy link
Collaborator

fendor commented Dec 21, 2023

Thanks for the bug report!

This was an accident when hls-stan-plugin was reintroduced. The vscode-haskell plugin disabled the hls-stan-plugin already by default.
However, thank you for the reminder, the next release definitely needs to disable the plugin by default again.

@Bodigrim
Copy link
Contributor

I came to raise the same issue, motivated by kowainik/stan#550.

@0rphee
Copy link
Collaborator

0rphee commented Dec 22, 2023

Until the stan plugin takes into account .stan.toml config files, the best way to ignore this suggestions would be to disable the plugin. After that, if you are still interested in other diagnostics, you can create a global ~/.stan.toml to silence particular observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants