Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn unknown fields in hie.yaml into warnings #344

Open
fendor opened this issue Apr 13, 2022 · 1 comment
Open

Turn unknown fields in hie.yaml into warnings #344

fendor opened this issue Apr 13, 2022 · 1 comment
Labels
good first issue Good for newcomers ZuriHac

Comments

@fendor
Copy link
Collaborator

fendor commented Apr 13, 2022

Until now, we threw an error message. The point being that you notice you didn't write the correct configuration and something is not right.

This will make it hard to introduce new optional keys, because older HLS versions will now choke on that config.

I think a warning is better. cabal-install also does this:

$ cabal build
Warning: /home/hasufell/git/stack2cabal/cabal.project: Unrecognized field
'foo' on line 11

Originally posted by @hasufell in #329 (comment)

@fendor fendor added the good first issue Good for newcomers label Apr 13, 2022
@fendor
Copy link
Collaborator Author

fendor commented May 6, 2022

Seems like yaml and aeson can't really report unknown fields as warnings T_T
haskell/aeson#808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ZuriHac
Projects
Development

No branches or pull requests

2 participants