Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll bar overlaps with last row on the browse data page #1049

Closed
coco98 opened this issue Nov 17, 2018 · 1 comment
Closed

Scroll bar overlaps with last row on the browse data page #1049

coco98 opened this issue Nov 17, 2018 · 1 comment
Labels
c/console Related to console k/bug Something isn't working

Comments

@coco98
Copy link
Contributor

coco98 commented Nov 17, 2018

Refer screenshot:
screenshot 2018-11-16 at 4 56 42 pm
@coco98 coco98 added k/bug Something isn't working c/console Related to console labels Nov 17, 2018
@coco98 coco98 changed the title Scroll bar overlaps with last row on the browse data issues Scroll bar overlaps with last row on the browse data page Nov 17, 2018
@WickedBrat
Copy link
Contributor

@coco98 It appears to be fixed.
Screenshot:
screenshot from 2018-12-16 01-16-35

surendran82 added a commit to surendran82/graphql-engine that referenced this issue Jan 7, 2019
@surendran82
Fixes hasura#1303, hasura#1049 and hasura#1282
a583a47
@surendran82 surendran82 mentioned this issue Jan 7, 2019
Merged
21 tasks
hasura-bot pushed a commit that referenced this issue Sep 10, 2024
@danieljharvey @hasura-bot
frontends/graphql crate (#1049)
50e1ab5 
<!-- The PR description should answer 2 important questions: -->

### What

This extracts a GraphQL frontend crate from the `execute` crate. This
contains all the top level functions, as opposed to what remains in
`execute`, which concerns itself with the creation and execution of
plans.

This only moves code around and organises it a little more neatly, and
so makes no functional changes. The follow up will be to create and
expose a neater API.

Next steps:

- Arguably what is left in `execute` is now better named `plan`, but
this PR was already big enough.
- Once we have more than one `frontend`, the functions in `steps.rs` in
this crate should probably be shared somewhere.

### How

Moving files around.

V3_GIT_ORIGIN_REV_ID: 0e54310a27d06905ed1967395e97ab47751b65dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/console Related to console k/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coco98 @WickedBrat