Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-apollo-todo example app ui fixes #1091

Merged
merged 3 commits into from
Nov 22, 2018
Merged

react-apollo-todo example app ui fixes #1091

merged 3 commits into from
Nov 22, 2018

Conversation

surendran82
Copy link
Contributor

@surendran82 surendran82 commented Nov 22, 2018 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@shahidhk shahidhk changed the title React todo app ui fixes react-apollo-todo example app ui fixes Nov 22, 2018
@shahidhk shahidhk merged commit 9d53f38 into hasura:master Nov 22, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1091.herokuapp.com is deleted

@shahidhk shahidhk added the c/community Related to community content label Nov 22, 2018
hasura-bot pushed a commit that referenced this pull request Sep 10, 2024
@danieljharvey @hasura-bot
Basic test framework for jsonapi (#1091)
a275966 
<!-- The PR description should answer 2 important questions: -->

### What

Let's add a test!

(and check it still works 👍 )

<img width="405" alt="Screenshot 2024-09-10 at 13 05 01"
src="https://github.com/user-attachments/assets/6a49feaa-bd0b-4137-a9d5-a1e1336d9fa6">

### How

Glob a folder for test files, parse them and run them against the
functions.

V3_GIT_ORIGIN_REV_ID: cc3e0d8cfb6f5eaa58cf72dab97e7220a57e7673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees
No one assigned
Labels
c/community Related to community content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surendran82 @hasura-bot @praveenweb @shahidhk