Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console build system #1104

Closed
wants to merge 47 commits into from
Closed

Console build system #1104

wants to merge 47 commits into from

Conversation

arvi3411301
Copy link
Member

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/console Related to console c/build-system Related to the build-release system s/wip Status: This issue is a work in progress labels Nov 23, 2018
@hasura-bot
Copy link
Contributor

Review app for commit dcef50a deployed to Heroku: https://hge-ci-pull-1104.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1104-dcef50a

@hasura-bot
Copy link
Contributor

Review app for commit c26dc94 deployed to Heroku: https://hge-ci-pull-1104.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1104-c26dc94

@hasura-bot
Copy link
Contributor

Review app for commit e1f1593 deployed to Heroku: https://hge-ci-pull-1104.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1104-e1f1593

@hasura-bot
Copy link
Contributor

Review app for commit 5694c0c deployed to Heroku: https://hge-ci-pull-1104.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1104-5694c0c

@shahidhk
Copy link
Member

Will revisit later.

@shahidhk shahidhk closed this Jan 29, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1104.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Sep 12, 2024
@danieljharvey @hasura-bot
Split NDC query from processing (#1104)
d1f4870 
<!-- The PR description should answer 2 important questions: -->

### What

Our function for fetching from NDC is wrapped up in remote joins and
GraphQL-shaped processing. As a first step, let's split those concerns.

### How

Split one function into three. Functional no-op.

V3_GIT_ORIGIN_REV_ID: e8a4690968829a4cb3695745d5b1741007fe0ced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c/build-system Related to the build-release system c/console Related to console s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvi3411301 @hasura-bot @shahidhk @karthikvt26