update example apps for uniform deployment #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app for commit e17d54f deployed to Heroku: https://hge-ci-pull-1105.herokuapp.com |
|
Review app for commit 272374c deployed to Heroku: https://hge-ci-pull-1105.herokuapp.com |
|
Review app https://hge-ci-pull-1105.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…e is missing from GraphQlConfig (#1105) ### What This PR is similar to #1079 in that it relaxes a build error that occurs into a warning. If you define a `Model` with aggregates but you haven't defined the `query.aggregate` section in your `GraphqlConfig`, then you currently get a build error telling you to do it. This PR relaxes this to a warning and aggregates are just omitted from the Model GraphQL API schema. ### How The error is converted to an issue in metadata resolve. An existing test that tested that error has been shifted to a passing test and the new raised issue can be seen at the bottom of the resolved metadata snapshot. V3_GIT_ORIGIN_REV_ID: b864be90141e2a8940fa9a6269beb24021880636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: