Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKING ISSUE] Refactoring client deregister listener behaviour [API-2081] #398

Open
ghost opened this issue Jan 26, 2021 · 2 comments
Open
Labels
Jira Creates a corresp. Jira issue in the APIs project. Source: Tracking Originated from the Tracking bot.

Comments

@ghost
Copy link

ghost commented Jan 26, 2021

The tracking issue for the Java side PR.

Refactoring client deregister listener behaviour

See hazelcast/hazelcast#17646 for details.


We were returning false as the return value if we were not
successuflly deregister from any member and events was able to
continue to delivered for non deregistered members.

We have changed the behaviour so that we return true if a
registration is found always. And after this point, user will not
get any event. We will cleanup all the local handlers right away
to make sure of that.

Secondly we have set invocation timeout as infinite so that the
deregistartion from a connection is retried as long as the
connection is there until it is succesful.

I have left logging the exception when there is an unexpected
failure. We do not expect any but this is to be able to diagnose
if the unexpected happens.

@zpqrtbnk zpqrtbnk added the Source: Tracking Originated from the Tracking bot. label Apr 9, 2021
@emreyigit
Copy link
Collaborator

.Net client doesn't set invocation timeouts individually. However, the change can be applied.

@emreyigit emreyigit added the Jira Creates a corresp. Jira issue in the APIs project. label Jul 4, 2023
@github-actions github-actions bot changed the title [TRACKING ISSUE] Refactoring client deregister listener behaviour [TRACKING ISSUE] Refactoring client deregister listener behaviour [API-2081] Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Internal Jira issue: API-2081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Creates a corresp. Jira issue in the APIs project. Source: Tracking Originated from the Tracking bot.
Projects
None yet
Development

No branches or pull requests

2 participants