Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrays possibly being transposed when converting NWB files from HDF5 to ZARR #45

Closed
oruebel opened this issue Dec 13, 2022 · 2 comments
Closed
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users

Comments

@oruebel
Copy link
Contributor

oruebel commented Dec 13, 2022

The tutorial for converting NWB data from HDF5 to Zarr, currently shows the following warnings (see also See https://hdmf-zarr.readthedocs.io/en/latest/tutorials/plot_convert_nwb.html#read-the-zarr-file-back-in)

Screen Shot 2022-12-13 at 12 31 26 AM

In particular the warning warn("Length of data does not match length of timestamps. Your data may be transposed. Time should be on " is something that should be looked at, as it appears that (some) arrays may for some reason be transposed in the conversion.

@oruebel oruebel added category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users labels Dec 13, 2022
@oruebel
Copy link
Contributor Author

oruebel commented Dec 24, 2022

Using the latest version of PyNWB and HDMF locally, the warning we see currently with warn("Length of data does not match length of timestamps. Your data may be transposed. Time should be on " does not occur, but instead the following warnings are now being raised:

/Users/oruebel/Devel/nwb/pynwb/src/pynwb/core.py:47: UserWarning: OpticalSeries 'StimulusPresentation_encoding': The number of frame indices in 'starting_frame' should have the same length as 'external_file'.
  warn(error_msg)
/Users/oruebel/Devel/nwb/pynwb/src/pynwb/core.py:47: UserWarning: OpticalSeries 'StimulusPresentation_encoding': Either external_file or data must be specified (not None), but not both.
  warn(error_msg)

Reading the data directly from HDF5 yields the same warnings, i.e., these warnings are actually due to errors in the file that is being used in the tutorial rather than indicating and error in the library.

@oruebel
Copy link
Contributor Author

oruebel commented Dec 24, 2022

I also tested in the regular tutorial, and it looks like arrays are indeed not being transposed. It appears that the warnings currently may be due to versions of PyNWB/HDMF used, that have already been addressed on the dev branches of those libraries. The new warnings for OpticalSeries are correct and are due to errors in the file that is being used.

Closing this issue as it does not appear to be an issue in HDMF_ZARR.

@oruebel oruebel closed this as completed Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

No branches or pull requests

1 participant