From 94e9e3dfa3d4ddb965cdddfb5f6f7f2597fde4ca Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Thu, 18 Aug 2022 16:24:08 -0700 Subject: [PATCH] Fix upload of assets in deploy release CI (#754) --- .github/workflows/deploy_release.yml | 4 ++++ CHANGELOG.md | 11 ++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/deploy_release.yml b/.github/workflows/deploy_release.yml index 888d6717a..7f66ccd8e 100644 --- a/.github/workflows/deploy_release.yml +++ b/.github/workflows/deploy_release.yml @@ -52,4 +52,8 @@ jobs: python -m pip install "click<8" githubrelease githubrelease --github-token ${{ secrets.BOT_GITHUB_TOKEN }} release hdmf-dev/hdmf \ create ${{ github.ref_name }} --name ${{ github.ref_name }} \ + --publish + # upload assets in a separate command until https://github.com/j0057/github-release/issues/67 is resolved + githubrelease --github-token ${{ secrets.BOT_GITHUB_TOKEN }} asset hdmf-dev/hdmf \ + upload ${{ github.ref_name }} \ --publish dist/* diff --git a/CHANGELOG.md b/CHANGELOG.md index 92f3a3e94..666889e94 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,17 +1,22 @@ # HDMF Changelog +## HDMF 3.4.1 (August 8, 2022) + +### Bug fixes +- Fixed deploy release CI. @rly ([#754](https://github.com/hdmf-dev/hdmf/pull/754)) + ## HDMF 3.4.0 (August 5, 2022) ### Minor improvements - Allow manual triggering of some GitHub Actions. @rly ([#744](https://github.com/hdmf-dev/hdmf/pull/744)) -- Relax input validation of `HDF5IO` to allow for s3fs support. Existing arguments of `HDF5IO` are modified as follows: i) `mode` was given a default value of "r", ii) `path` was given a default value of `None`, and iii) `file` can now accept an `S3File` type argument. @bendichter ([#746](https://github.com/hdmf-dev/hdmf/pull/746)) -- Added ability to create and get back handle to empty HDF5 dataset. @ajtritt (#747) +- Relaxed input validation of `HDF5IO` to allow for s3fs support. Existing arguments of `HDF5IO` are modified as follows: i) `mode` was given a default value of "r", ii) `path` was given a default value of `None`, and iii) `file` can now accept an `S3File` type argument. @bendichter ([#746](https://github.com/hdmf-dev/hdmf/pull/746)) +- Added ability to create and get back handle to empty HDF5 dataset. @ajtritt ([#747](https://github.com/hdmf-dev/hdmf/pull/747)) - Added `AbstractContainer._in_construct_mode` that is set and modified only by the ObjectMapper when constructing an object from a builder read from a file. Subclasses of `AbstractContainer` can check `_in_construct_mode` during the initialization phase as part of ``__init__`` to distinguish between actions during construction (i.e., read from disk) vs. creation by the user, e.g., to determine whether to raise a warning or error when encountering invalid data to support reading and correcting data that is invalid while preventing creation - of new data that is invalid. @rly (#751) + of new data that is invalid. @rly ([#751](https://github.com/hdmf-dev/hdmf/pull/751)) ### Bug fixes - Fixed PyNWB dev CI. @rly ([#749](https://github.com/hdmf-dev/hdmf/pull/749))