From 7e43750a72e837e1cdcaf3019d4cdae84b055329 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Wed, 20 Jul 2022 22:14:09 -0700 Subject: [PATCH 1/2] Fix pynwb test failing due to coverage not finding sources (#749) --- .github/workflows/run_pynwb_tests.yml | 5 +++-- CHANGELOG.md | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run_pynwb_tests.yml b/.github/workflows/run_pynwb_tests.yml index 2b19610d1..43edf309f 100644 --- a/.github/workflows/run_pynwb_tests.yml +++ b/.github/workflows/run_pynwb_tests.yml @@ -32,9 +32,10 @@ jobs: git clone https://github.com/NeurodataWithoutBorders/pynwb.git --recurse-submodules cd pynwb python -m pip install -r requirements-dev.txt -r requirements.txt - python -m pip install . # this will install a particular version of hdmf instead of the current one + # must install in editable mode for coverage to find sources + python -m pip install -e . # this will install a pinned version of hdmf instead of the current one cd .. - python -m pip uninstall -y hdmf + python -m pip uninstall -y hdmf # uninstall the pinned version of hdmf python -m pip install . # reinstall current branch of hdmf python -m pip list diff --git a/CHANGELOG.md b/CHANGELOG.md index 84210732c..f8be3b7c3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,13 @@ # HDMF Changelog ## HDMF 3.3.3 (Upcoming) + +### Minor improvements - Relax input validation of `HDF5IO` to allow for s3fs support. Existing arguments of `HDF5IO` are modified as follows: i) `mode` was given a default value of "r", ii) `path` was given a default value of `None`, and iii) `file` can now accept an `S3File` type argument. @bendichter ([#746](https://github.com/hdmf-dev/hdmf/pull/746)) +### Bug fixes +- Fixed PyNWB dev CI. @rly ([#749](https://github.com/hdmf-dev/hdmf/pull/749)) + ## HDMF 3.3.2 (June 27, 2022) ### Bug fixes From ef0a800751415b02228e348e360175af390ee5a4 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Wed, 20 Jul 2022 22:24:46 -0700 Subject: [PATCH 2/2] Allow manual triggering of some GitHub Actions (#744) * Allow manual triggering of some GitHub Actions * Update changelog --- .github/workflows/check_external_links.yml | 1 + .github/workflows/run_all_tests.yml | 1 + .github/workflows/run_coverage.yml | 1 + .github/workflows/run_pynwb_tests.yml | 1 + CHANGELOG.md | 3 ++- 5 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check_external_links.yml b/.github/workflows/check_external_links.yml index 55e957bfc..10ea8a683 100644 --- a/.github/workflows/check_external_links.yml +++ b/.github/workflows/check_external_links.yml @@ -3,6 +3,7 @@ on: pull_request: schedule: - cron: '0 5 * * *' # once per day at midnight ET + workflow_dispatch: jobs: check-external-links: diff --git a/.github/workflows/run_all_tests.yml b/.github/workflows/run_all_tests.yml index 9f3e255c1..b32edf29f 100644 --- a/.github/workflows/run_all_tests.yml +++ b/.github/workflows/run_all_tests.yml @@ -5,6 +5,7 @@ on: push: tags: # run only on new tags that follow semver - '/^[0-9]+(\.[0-9]+)?(\.[0-9]+)?$/' + workflow_dispatch: jobs: run-all-tests: diff --git a/.github/workflows/run_coverage.yml b/.github/workflows/run_coverage.yml index 2a82122b5..b84703350 100644 --- a/.github/workflows/run_coverage.yml +++ b/.github/workflows/run_coverage.yml @@ -7,6 +7,7 @@ on: - 'latest' - 'latest-tmp' pull_request: + workflow_dispatch: jobs: run-coverage: diff --git a/.github/workflows/run_pynwb_tests.yml b/.github/workflows/run_pynwb_tests.yml index 43edf309f..afba1dfd5 100644 --- a/.github/workflows/run_pynwb_tests.yml +++ b/.github/workflows/run_pynwb_tests.yml @@ -3,6 +3,7 @@ on: pull_request: schedule: - cron: '0 5 * * *' # once per day at midnight ET + workflow_dispatch: jobs: run-tests: diff --git a/CHANGELOG.md b/CHANGELOG.md index f8be3b7c3..c5e495dab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,9 @@ # HDMF Changelog -## HDMF 3.3.3 (Upcoming) +## HDMF 3.4.0 (upcoming) ### Minor improvements +- Allow manual triggering of some GitHub Actions. @rly ([#744](https://github.com/hdmf-dev/hdmf/pull/744)) - Relax input validation of `HDF5IO` to allow for s3fs support. Existing arguments of `HDF5IO` are modified as follows: i) `mode` was given a default value of "r", ii) `path` was given a default value of `None`, and iii) `file` can now accept an `S3File` type argument. @bendichter ([#746](https://github.com/hdmf-dev/hdmf/pull/746)) ### Bug fixes