Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot write multi-dimensional string arrays #1137

Closed
rly opened this issue Jun 27, 2024 · 1 comment · Fixed by #1173
Closed

Cannot write multi-dimensional string arrays #1137

rly opened this issue Jun 27, 2024 · 1 comment · Fixed by #1173
Assignees
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Milestone

Comments

@rly
Copy link
Contributor

rly commented Jun 27, 2024

This only works for 1-D string arrays. I think the if statement in this code is intended to check for structured arrays / compound dtypes. Else, execution should go to get_data_shape which gets the shape correctly.

elif isinstance(dtype, np.dtype):
data_shape = (len(data),)

@rly rly added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Jun 27, 2024
@rly rly added this to the 3.14.2 milestone Jun 27, 2024
@stephprince
Copy link
Contributor

See related issue here with tests: #1096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants