From 2afdca4543d66bf1bf66da64ebc3be5487738058 Mon Sep 17 00:00:00 2001 From: Yahor Yuzefovich Date: Mon, 19 Jun 2023 21:19:04 +0000 Subject: [PATCH] roachtest: fix tpchvec in some cases We recently introduced a minor bug in the tpchvec in c5c7eadb16f21f05f21c77a0642dffd9995b4412 where could use uninitialized helper to parse the test output, which can lead to a nil pointer when the slowness threshold is exceeded, and this is now fixed. Release note: None --- pkg/cmd/roachtest/tests/tpchvec.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/roachtest/tests/tpchvec.go b/pkg/cmd/roachtest/tests/tpchvec.go index fd32a07dbd44..321b269d144d 100644 --- a/pkg/cmd/roachtest/tests/tpchvec.go +++ b/pkg/cmd/roachtest/tests/tpchvec.go @@ -259,7 +259,7 @@ func (p *tpchVecPerfTest) postTestRunHook( // Check whether we can reproduce this slowness to prevent false // positives. - var helper tpchVecPerfHelper + helper := newTpchVecPerfHelper(runConfig.setupNames) for setupIdx, setup := range runConfig.clusterSetups { performClusterSetup(t, conn, setup) result, err := c.RunWithDetailsSingleNode(