From aaffd4d4efbcf7ff8770d78cb9e82b1743f11b05 Mon Sep 17 00:00:00 2001 From: Wenying Dong Date: Wed, 12 Oct 2022 21:32:31 +0800 Subject: [PATCH] Add unit test in path pkg/agent/interfacestore (#4265) Signed-off-by: wenyingd --- .../interfacestore/interface_cache_test.go | 257 ++++++++++++++++++ pkg/agent/interfacestore/types.go | 6 - 2 files changed, 257 insertions(+), 6 deletions(-) create mode 100644 pkg/agent/interfacestore/interface_cache_test.go diff --git a/pkg/agent/interfacestore/interface_cache_test.go b/pkg/agent/interfacestore/interface_cache_test.go new file mode 100644 index 00000000000..21a44f09cc1 --- /dev/null +++ b/pkg/agent/interfacestore/interface_cache_test.go @@ -0,0 +1,257 @@ +// Copyright 2022 Antrea Authors +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package interfacestore + +import ( + "net" + "reflect" + "testing" + + "github.com/stretchr/testify/assert" + + "antrea.io/antrea/pkg/agent/util" + "antrea.io/antrea/pkg/ovs/ovsconfig" +) + +var ( + podMAC, _ = net.ParseMAC("11:22:33:44:55:66") + podIP = net.ParseIP("1.2.3.4") + gwIP = net.ParseIP("1.2.3.1") + hostIP = net.ParseIP("2.2.2.2") + ipsecTunnelIP = net.ParseIP("2.2.2.3") + nodeName = "n1" + peerNodeName = "n2" +) + +func TestNewInterfaceStore(t *testing.T) { + t.Run("testContainerInterface", testContainerInterface) + t.Run("testGatewayInterface", testGatewayInterface) + t.Run("testTunnelInterface", testTunnelInterface) + t.Run("testUplinkInterface", testUplinkInterface) + t.Run("testTrafficControlInterface", testTrafficControlInterface) + t.Run("testExternalEntityInterface", testEntityInterface) +} + +func testContainerInterface(t *testing.T) { + store := NewInterfaceStore() + containerInterface := NewContainerInterface("ns0p0c0", "c0", "p0", "ns0", podMAC, []net.IP{podIP}, 2) + containerInterface.OVSPortConfig = &OVSPortConfig{ + OFPort: 12, + PortUUID: "1234567890", + } + containerInterfaceKey := util.GenerateContainerInterfaceKey(containerInterface.ContainerID) + store.Initialize([]*InterfaceConfig{containerInterface}) + assert.Equal(t, 1, store.Len()) + storedIface, exists := store.GetInterface(containerInterfaceKey) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, containerInterface)) + // The name of Container InterfaceConfig is not the key in InterfaceStore + _, exists = store.GetInterface(containerInterface.InterfaceName) + assert.False(t, exists) + _, exists = store.GetInterfaceByName(containerInterface.InterfaceName) + assert.True(t, exists) + _, exists = store.GetContainerInterface(containerInterface.ContainerID) + assert.True(t, exists) + _, exists = store.GetInterfaceByIP(podIP.String()) + assert.True(t, exists) + _, exists = store.GetInterfaceByOFPort(uint32(containerInterface.OVSPortConfig.OFPort)) + assert.True(t, exists) + ifaces := store.GetContainerInterfacesByPod(containerInterface.PodName, containerInterface.PodNamespace) + assert.Equal(t, 1, len(ifaces)) + assert.True(t, reflect.DeepEqual(ifaces[0], containerInterface)) + ifaceNames := store.GetInterfaceKeysByType(ContainerInterface) + assert.Equal(t, 1, len(ifaceNames)) + assert.Equal(t, containerInterfaceKey, ifaceNames[0]) + assert.Equal(t, 1, store.GetContainerInterfaceNum()) + store.DeleteInterface(containerInterface) + assert.Equal(t, 0, store.GetContainerInterfaceNum()) + _, exists = store.GetContainerInterface(containerInterface.ContainerID) + assert.False(t, exists) + _, exists = store.GetInterfaceByIP(containerInterface.IPs[0].String()) + assert.False(t, exists) + containerInterface.IPs = nil + store.AddInterface(containerInterface) + assert.Equal(t, 1, store.GetContainerInterfaceNum()) + _, exists = store.GetInterfaceByIP(podIP.String()) + assert.False(t, exists) +} + +func testGatewayInterface(t *testing.T) { + gatewayInterface := NewGatewayInterface("antrea-gw0") + gatewayInterface.IPs = []net.IP{gwIP} + gatewayInterface.OVSPortConfig = &OVSPortConfig{ + OFPort: 13, + PortUUID: "1234567890", + } + testGeneralInterface(t, gatewayInterface, GatewayInterface) +} + +func testTunnelInterface(t *testing.T) { + store := NewInterfaceStore() + tunnelInterface := NewTunnelInterface("antrea-tun0", ovsconfig.GeneveTunnel, 6081, hostIP, false) + tunnelInterface.IPs = []net.IP{hostIP} + tunnelInterface.OVSPortConfig = &OVSPortConfig{ + OFPort: 14, + PortUUID: "1234567890", + } + ipsecTunnelInterface := NewIPSecTunnelInterface("antrea-ipsec0", ovsconfig.ERSPANTunnel, nodeName, hostIP, "abcdefg", peerNodeName) + ipsecTunnelInterface.IPs = []net.IP{ipsecTunnelIP} + ipsecTunnelInterface.OVSPortConfig = &OVSPortConfig{ + OFPort: 15, + PortUUID: "1234567890", + } + store.Initialize([]*InterfaceConfig{tunnelInterface, ipsecTunnelInterface}) + assert.Equal(t, 2, store.Len()) + for _, tunIface := range []*InterfaceConfig{tunnelInterface, ipsecTunnelInterface} { + storedIface, exists := store.GetInterfaceByName(tunIface.InterfaceName) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, tunIface)) + storedIface, exists = store.GetInterfaceByIP(tunIface.IPs[0].String()) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, tunIface)) + storedIface, exists = store.GetInterfaceByOFPort(uint32(tunIface.OVSPortConfig.OFPort)) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, tunIface)) + } + + ipsecTunnelKey := util.GenerateNodeTunnelInterfaceKey(ipsecTunnelInterface.NodeName) + storedIface, exists := store.GetInterface(ipsecTunnelKey) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, ipsecTunnelInterface)) + _, exists = store.GetInterface(ipsecTunnelInterface.InterfaceName) + assert.False(t, exists) + storedIface, exists = store.GetInterface(tunnelInterface.InterfaceName) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, tunnelInterface)) + storedIface, exists = store.GetNodeTunnelInterface(nodeName) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, ipsecTunnelInterface)) + _, exists = store.GetNodeTunnelInterface(peerNodeName) + assert.False(t, exists) + + ifaceNames := store.GetInterfaceKeysByType(TunnelInterface) + assert.Equal(t, 2, len(ifaceNames)) + store.DeleteInterface(ipsecTunnelInterface) + assert.Equal(t, 1, len(store.GetInterfaceKeysByType(TunnelInterface))) + _, exists = store.GetInterfaceByName(ipsecTunnelInterface.InterfaceName) + assert.False(t, exists) + store.AddInterface(ipsecTunnelInterface) + ifaceNames = store.GetInterfaceKeysByType(TunnelInterface) + assert.Equal(t, 2, len(ifaceNames)) + _, exists = store.GetInterfaceByName(ipsecTunnelInterface.InterfaceName) + assert.True(t, exists) +} + +func testUplinkInterface(t *testing.T) { + uplinkInterface := NewUplinkInterface("ens224") + uplinkInterface.IPs = []net.IP{hostIP} + uplinkInterface.OVSPortConfig = &OVSPortConfig{ + OFPort: 16, + PortUUID: "1234567890", + } + testGeneralInterface(t, uplinkInterface, UplinkInterface) +} + +func testTrafficControlInterface(t *testing.T) { + tcInterface := NewTrafficControlInterface("tc0") + tcInterface.IPs = []net.IP{hostIP} + tcInterface.OVSPortConfig = &OVSPortConfig{ + OFPort: 17, + PortUUID: "1234567890", + } + testGeneralInterface(t, tcInterface, TrafficControlInterface) +} + +func testEntityInterface(t *testing.T) { + store := NewInterfaceStore() + portConfig := &OVSPortConfig{OFPort: 18, PortUUID: "123456789"} + uplinkConfig := &OVSPortConfig{OFPort: 19, PortUUID: "987654321"} + entityIPv4 := net.ParseIP("2.3.4.5") + entityIPv6 := net.ParseIP("abcd::1234") + entityIPs := []net.IP{ + entityIPv4, + entityIPv6, + } + entityInterface := newExternalEntityInterface("vm1-ens192", entityIPs, "ens192", "ns2", portConfig, uplinkConfig) + store.Initialize([]*InterfaceConfig{entityInterface}) + storedIface, exists := store.GetInterface(entityInterface.InterfaceName) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, entityInterface)) + assert.Equal(t, entityIPv4, storedIface.GetIPv4Addr()) + assert.Equal(t, entityIPv6, storedIface.GetIPv6Addr()) + _, exists = store.GetInterfaceByName(entityInterface.InterfaceName) + assert.True(t, exists) + for _, entityIP := range entityInterface.IPs { + _, exists = store.GetInterfaceByIP(entityIP.String()) + assert.True(t, exists) + } + _, exists = store.GetInterfaceByOFPort(uint32(entityInterface.OVSPortConfig.OFPort)) + assert.True(t, exists) + _, exists = store.GetInterfaceByOFPort(uint32(entityInterface.UplinkPort.OFPort)) + assert.False(t, exists) + ifaces := store.GetInterfacesByEntity(entityInterface.EntityName, entityInterface.EntityNamespace) + assert.Equal(t, 1, len(ifaces)) + assert.True(t, reflect.DeepEqual(ifaces[0], entityInterface)) + ifaceNames := store.GetInterfaceKeysByType(ExternalEntityInterface) + assert.Equal(t, 1, len(ifaceNames)) + assert.Equal(t, entityInterface.InterfaceName, ifaceNames[0]) + store.DeleteInterface(entityInterface) + assert.Equal(t, 0, len(store.GetInterfaceKeysByType(ExternalEntityInterface))) + store.AddInterface(entityInterface) + assert.Equal(t, 1, len(store.GetInterfaceKeysByType(ExternalEntityInterface))) +} + +func testGeneralInterface(t *testing.T, ifaceConfig *InterfaceConfig, ifaceType InterfaceType) { + store := NewInterfaceStore() + store.Initialize([]*InterfaceConfig{ifaceConfig}) + storedIface, exists := store.GetInterface(ifaceConfig.InterfaceName) + assert.True(t, exists) + assert.True(t, reflect.DeepEqual(storedIface, ifaceConfig)) + _, exists = store.GetInterfaceByName(ifaceConfig.InterfaceName) + assert.True(t, exists) + _, exists = store.GetInterfaceByIP(ifaceConfig.IPs[0].String()) + assert.True(t, exists) + _, exists = store.GetInterfaceByOFPort(uint32(ifaceConfig.OVSPortConfig.OFPort)) + assert.True(t, exists) + fooPort := uint32(1) + _, exists = store.GetInterfaceByOFPort(fooPort) + assert.False(t, exists) + ifaceNames := store.GetInterfaceKeysByType(ifaceType) + assert.Equal(t, 1, len(ifaceNames)) + assert.Equal(t, ifaceConfig.InterfaceName, ifaceNames[0]) + store.DeleteInterface(ifaceConfig) + assert.Equal(t, 0, len(store.GetInterfaceKeysByType(ifaceType))) + store.AddInterface(ifaceConfig) + ifaceNames = store.GetInterfaceKeysByType(ifaceType) + assert.Equal(t, 1, len(ifaceNames)) + assert.Equal(t, ifaceConfig.InterfaceName, ifaceNames[0]) + ifaces := store.GetInterfacesByType(ifaceType) + assert.Equal(t, 1, len(ifaces)) + assert.Equal(t, ifaceConfig, ifaces[0]) +} + +func newExternalEntityInterface(name string, entityIPs []net.IP, entityName string, entityNamespace string, ovsPortConfig, uplinkPortConfig *OVSPortConfig) *InterfaceConfig { + return &InterfaceConfig{ + Type: ExternalEntityInterface, + InterfaceName: name, + IPs: entityIPs, + OVSPortConfig: ovsPortConfig, + EntityInterfaceConfig: &EntityInterfaceConfig{ + EntityName: entityName, + EntityNamespace: entityNamespace, + UplinkPort: uplinkPortConfig, + }, + } +} diff --git a/pkg/agent/interfacestore/types.go b/pkg/agent/interfacestore/types.go index 06b4215faee..56a501224a8 100644 --- a/pkg/agent/interfacestore/types.go +++ b/pkg/agent/interfacestore/types.go @@ -31,8 +31,6 @@ const ( TunnelInterface // UplinkInterface is used to mark current interface is for uplink port UplinkInterface - // HostInterface is used to mark current interface is for host - HostInterface // TrafficControlInterface is used to mark current interface is for traffic control port TrafficControlInterface // ExternalEntityInterface is used to mark current interface is for ExternalEntity Endpoint @@ -173,10 +171,6 @@ func NewUplinkInterface(uplinkName string) *InterfaceConfig { return uplinkConfig } -func NewHostInterface(hostInterfaceName string) *InterfaceConfig { - return &InterfaceConfig{InterfaceName: hostInterfaceName, Type: HostInterface} -} - func NewTrafficControlInterface(interfaceName string) *InterfaceConfig { trafficControlConfig := &InterfaceConfig{InterfaceName: interfaceName, Type: TrafficControlInterface} return trafficControlConfig