Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md says browser_validations = true by default, but generator makes it false #1746

Open
viktorsmari opened this issue Aug 19, 2021 · 0 comments
Open

README.md says browser_validations = true by default, but generator makes it false #1746

viktorsmari opened this issue Aug 19, 2021 · 0 comments

Comments

@viktorsmari
Copy link

Similar to #1216 which was closed

Environment

  • Ruby 2.7.3
  • Rails 6.1.3.2
  • Simple Form 5.1.0

Current behavior

rails generate simple_form:install
Creates config/initializers/simple_form.rb where line 130 is:

config.browser_validations = false

Expected behavior

The README.md says that it is true by default
https://github.com/heartcombo/simple_form/blame/master/README.md#L1111-L1113

Should the generator not create it as true if the readme says true is the default?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viktorsmari