Feat: Multiple tokens form #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stanislaw <[email protected]>
BartoszSolkaArianelabs
requested review from
BartoszSolkaArianelabs,
michalrozekariane and
se7enarianelabs
michalrozekariane
approved these changes
Mar 12, 2024
src/App.tsx
Outdated
Comment on lines
80
to
84
| formData.map(async (item) => { | ||
| const tokenId = item.tokenId; | ||
| const minAmount = item.minAmount; | ||
| const url = `${nodeUrl}/api/v1/tokens/${tokenId}/balances?account.balance=gte:${minAmount}&limit=100`; | ||
| return fetchData(url); |
There was a problem hiding this comment.
I think you can destructure tokenId and minAmount here right away
There was a problem hiding this comment.
Done
…threshold-for-each Signed-off-by: Stanislaw <[email protected]> # Conflicts: # src/App.tsx # src/components/HoldersForm.tsx # src/dictionary/en.json
Signed-off-by: Stanislaw <[email protected]>
…threshold-for-each Signed-off-by: Stanislaw <[email protected]> # Conflicts: # src/App.tsx # src/components/HoldersForm.tsx # src/dictionary/en.json # src/utils/formSchema.ts
piotrswierzy
suggested changes
Mar 13, 2024
Comment on lines
+58
to
+70
| const filterData = (responses: Balance[][], isAllConditionsRequired: boolean): Balance[] => { | ||
| let data = responses.flatMap((response) => response); | ||
|
|
||
| if (!response.ok) { | ||
| throw new Error(`${dictionary.httpError} ${response.status}`); | ||
| } | ||
| if (isAllConditionsRequired) { | ||
| return data.filter( | ||
| (balance, index, self) => | ||
| self.findIndex((b) => b.account === balance.account) === index && | ||
| responses.every((response) => response.some((b) => b.account === balance.account)), | ||
| ); | ||
| } else { | ||
| return data.filter((balance, index, self) => self.findIndex((b) => b.account === balance.account) === index); | ||
| } | ||
| }; |
|
This PR is too outdated regarding #18 |
|
This PR is too outdated regarding #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16