Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed MarkupSafe version when Jinja2 bug is fixed #2028

Closed
TiBiBa opened this issue Feb 18, 2022 · 1 comment
Closed

Remove fixed MarkupSafe version when Jinja2 bug is fixed #2028

TiBiBa opened this issue Feb 18, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@TiBiBa
Copy link
Collaborator

TiBiBa commented Feb 18, 2022

This is a placeholder to ensure that we don't forget to remove the fixed MarkupSafe version 2.0.1 when the unittests breaking Jinja2 bug is solved. We should keep an eye out for the corresponding Jinja2 issue and remove the fixed version as soon as that one is solved an Jinja2 is updated within our project.

Related issue: pallets/jinja#1587

@TiBiBa TiBiBa self-assigned this Feb 18, 2022
@TiBiBa TiBiBa added the bug Something isn't working label Feb 18, 2022
@davidism
Copy link

davidism commented Feb 18, 2022

You are using an unsupported version of Jinja, please update to the latest version if possible. Additionally, please read https://hynek.me/articles/semver-will-not-save-you/, then use a tool like pip-tools to pin your dependencies and control when you get updates. Be sure to run your tests with deprecation warnings treated as errors so that you get notified of these types of changes early.

@TiBiBa TiBiBa closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants