From 25efa9dfbc5dd699e05f03b2007b5f6655f973d5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20Pelay?= <pelayjesus@gmail.com>
Date: Thu, 23 Nov 2023 12:41:35 -0400
Subject: [PATCH 1/2] removes waits and creates fresh class before test

---
 .../class_page/second_teachers_invites.cy.js  | 41 ++++---------------
 1 file changed, 8 insertions(+), 33 deletions(-)

diff --git a/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js b/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js
index 3db6a19c0ae..b8aee502c65 100644
--- a/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js
+++ b/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js
@@ -1,31 +1,27 @@
 import {loginForTeacher, logout} from "../../tools/login/login.js"
 import { goToProfilePage } from "../../tools/navigation/nav";
+import { createClass } from "../../tools/classes/class";
 
 const secondTeachers = ["teacher2", "teacher3"]
 const invitesTable = body => body.find("#invites-block table")
 
 describe("Second teachers: invitations", () => {
-  it(`Invites ${secondTeachers.length} second teachers: by username`, () => {
-
+  before(() => {
     loginForTeacher();
+    createClass()
+  });
 
-    cy.wait(500);
-
+  it(`Invites ${secondTeachers.length} second teachers: by username`, () => {
+    loginForTeacher();
     cy.get(".view_class").first().click();
     cy.get('body').then($b => $b.find("#survey")).then($s => $s.length && $s.hide())
 
     for (const teacher of secondTeachers) {
-      cy.wait(500);
       
       cy.get("#add-second-teacher").click();
-      
-      // cy.get("#invite-student").click();
-      // cy.wait(2000)
       cy.get("#modal-prompt-input").type(teacher);
       cy.get("#modal-ok-button").click();
       
-      cy.wait(500);
-      
       cy.get("body").then(invitesTable).then(table => {
         if (table.length) {
           table = cy.get("#invites-block table")
@@ -37,24 +33,15 @@ describe("Second teachers: invitations", () => {
         }
       })
     }
-      //logout:
-    // logout();
   })
 
   it(`Tries duplicating ${secondTeachers[0]}'s invitation`, () => {
-
-    loginForTeacher()
-
+    loginForTeacher();
     cy.get(".view_class").first().click();
-    cy.wait(500);
-    cy.get('body').then($b => $b.find("#survey")).then($s => $s.length && $s.hide())
-
-    cy.wait(500);
 
     cy.get("#add-second-teacher").click();
     cy.get("#modal-prompt-input").type(secondTeachers[0]);
     cy.get("#modal-ok-button").click();
-    cy.wait(500);
 
     cy.get("#modal_alert_container")
     .should('be.visible')
@@ -66,26 +53,18 @@ describe("Second teachers: invitations", () => {
     goToProfilePage()
     cy.get("#messages").should("exist")
     cy.get("#messages #join").click()
-    logout();
   })
 
   it("Reads all second teachers", () => {
     loginForTeacher()
-    cy.get(".view_class").first().click();
-    cy.wait(500);
-    cy.get('body').then($b => $b.find("#survey")).then($s => $s.length && $s.hide())
+    cy.get(".view_class").first().click();        
     cy.get("#second_teachers_container .username_cell").should("include.text", secondTeachers[0])
-    logout()
   })
 
   it(`Deletes ${secondTeachers[1]}'s invitation`, () => {
 
     loginForTeacher();
-    cy.wait(500);
     cy.get(".view_class").first().click();
-    cy.wait(500);
-    cy.get('body').then($b => $b.find("#survey")).then($s => $s.length && $s.hide())
-
     cy.get("body").then(invitesTable).then(table => {
       // if not, then no invitation.
       if (table.length) {
@@ -93,17 +72,13 @@ describe("Second teachers: invitations", () => {
         console.log(table)
         table.should("exist")
         table.get(".remove_user_invitation").first().click()
-        cy.wait(500);
         cy.get("#modal-yes-button").click();
       } else {
         cy.log("Second teacher not deleted.")
       }
     })
-    
-    cy.wait(500);
     cy.get('body').then(invitesTable).then(table => 
       table.length && cy.get("#invites-block table").should("not.contain", secondTeachers[0]))
-    logout();
   })
 
 })

From 7f4f3c9020b8b8a890c432c46b34c2b19e6fca66 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20Pelay?= <pelayjesus@gmail.com>
Date: Thu, 23 Nov 2023 12:43:39 -0400
Subject: [PATCH 2/2] removes one more unncesserary check

---
 .../for-teacher_page/class_page/second_teachers_invites.cy.js    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js b/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js
index b8aee502c65..3a64e1dfe55 100644
--- a/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js
+++ b/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js
@@ -14,7 +14,6 @@ describe("Second teachers: invitations", () => {
   it(`Invites ${secondTeachers.length} second teachers: by username`, () => {
     loginForTeacher();
     cy.get(".view_class").first().click();
-    cy.get('body').then($b => $b.find("#survey")).then($s => $s.length && $s.hide())
 
     for (const teacher of secondTeachers) {