Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-optimal-dependency-setup-detection is not working correctly with prerelease-tags #31

Closed
heikomat opened this issue Jan 31, 2018 · 1 comment
Assignees

Comments

@heikomat
Copy link
Owner

When working with prerelease-tags in dependency-versions, they are incorrectly identified as incompatible, which results in warnings like this:

| 4 local modules are satisfied with version ^1.0.0-rc6 of @process-engine/process_engine, but some aren't:
|   version ^1.0.0-rc3 satisfies 1 local modules:
|     ./_integration_tests

^1.0.0-rc3 obviously does satisfy ^1.0.0-rc6 because of the ^.
The reason this happens is, that semver-intersect manipulates the supplied ranges in an incompatible way. I opened an Issue for that here: snyamathi/semver-intersect#4

This only makes the setup not be fully optimized, but should not result in broken installations!

@heikomat heikomat self-assigned this Jan 31, 2018
@heikomat
Copy link
Owner Author

heikomat commented Feb 1, 2018

This is fixed in 3.0.4 Thanks to snyamathi/semver-intersect#5 :)

@heikomat heikomat closed this as completed Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant