Skip to content

Commit

Permalink
Fix: DPL settings: do not reset solar_passthrough_enabled
Browse files Browse the repository at this point in the history
we must not reset the configuration switch value in this context. this
leads to solar passthrough being disabled once the DPL is disabled. when
re-enabling the DPL, solar passthrough is suddenly off, even though the
user configured it to be on.

the configuration switch can stay on. the DPL will still sanity-check
whether or not solar-passthrough can be used (checks if VE.Direct is
enabled) or it is irrelevant since the DPL is disabled.
  • Loading branch information
schlimmchen committed Sep 1, 2024
1 parent babb24a commit 5ad63e6
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions webapp/src/views/PowerLimiterAdminView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -501,11 +501,7 @@ export default defineComponent({
canUseSolarPassthrough() {
const cfg = this.powerLimiterConfigList;
const meta = this.powerLimiterMetaData;
const canUse = this.isEnabled() && meta.charge_controller_enabled && !cfg.is_inverter_solar_powered;
if (!canUse) {
cfg.solar_passthrough_enabled = false;
}
return canUse;
return this.isEnabled() && meta.charge_controller_enabled && !cfg.is_inverter_solar_powered;
},
canUseSoCThresholds() {
const cfg = this.powerLimiterConfigList;
Expand Down

0 comments on commit 5ad63e6

Please sign in to comment.