Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP26: Payment Notes #125

Closed
jamiew opened this issue Jan 29, 2021 · 8 comments
Closed

HIP26: Payment Notes #125

jamiew opened this issue Jan 29, 2021 · 8 comments
Labels

Comments

@jamiew
Copy link
Contributor

jamiew commented Jan 29, 2021

Author(s): @cvolkernick
Initial PR: #117
Start Date: 2021-01-24
Category: Technical

Rendered view:

https://github.com/helium/HIP/blob/master/0026-payment-notes.md

Summary:

This proposal suggests the addition of a new option for the Helium wallet PAY command: an optional (likely length/size restricted) alphanumeric memo/note field included with a wallet-to-wallet HNT payment transaction.

@DGKSK8LIFE
Copy link

DGKSK8LIFE commented Jan 29, 2021

messages are not required to be acknowledged or may be blocked/filtered entirely.

This functionality is essential to implement imo (to mitigate harassment/spam).

@abhay
Copy link
Contributor

abhay commented Apr 8, 2021

With support for memos in payment_v2 transactions coming in helium/blockchain-core#768, I propose we close this HIP and discussion and let the community built apps on top of memos.

@jamiew
Copy link
Contributor Author

jamiew commented Apr 8, 2021

Looks good to me. I'll defer to the HIP author @cvolkernick as far as closing this particular HIP vs. accepting this implementation vs. keeping this HIP open to invite a competing implementation.

helium/blockchain-core#768 is different from the HIP, but that is exactly what is supposed to happen during product development. IMHO 768 seems to balance blockchain efficiency with the more abstract goal of attaching identiifiers to payments, and the actual text of the "host-to-host messaging" could be implemented off-chain. That would also allow for more flexible options for identity and encryption.

@cvolkernick
Copy link
Contributor

Sounds reasonable to me, the blockchain core change seems to be fundamentally enabling the intent behind the HIP. It was never written with any particular implementation in mind, only to spur discussion.

@abhay
Copy link
Contributor

abhay commented Jun 11, 2021

Curious if we consider this closed now that memos have been implemented on chain and other apps can use memos to build more fully featured host to host messaging.

cc: @cvolkernick @jamiew

@cvolkernick
Copy link
Contributor

Will stand by my previous response from 4/8. Worst case another HIP can be drafted if things don't pan out as intended/desired. Thanks to the development team for the implementation.

@abhay
Copy link
Contributor

abhay commented Sep 6, 2021

Propose closing this @jamiew?

@jamiew
Copy link
Contributor Author

jamiew commented Sep 14, 2021

Marked Deployed. This is considered addressed by the addition of payment_memo_v2 in audit 63

Acceptance block: 869852
Acceptance block time: Thu Jun 3 09:06:49 PM UTC 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants