Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding confirmation message on save #1633

Closed
premell opened this issue Feb 8, 2022 · 2 comments · Fixed by #2267
Closed

Adding confirmation message on save #1633

premell opened this issue Feb 8, 2022 · 2 comments · Fixed by #2267
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@premell
Copy link

premell commented Feb 8, 2022

When saving there is no confirmation that it actually succeeded:
Helix:
image
nvim:
image

PS: This is such a small thing that I wasnt sure if I should even make an issue. However it might be a good issue, also there might be more places where messages would be nice

@premell premell added the C-enhancement Category: Improvements label Feb 8, 2022
@sudormrfbin sudormrfbin added E-good-first-issue Call for participation: Issues suitable for new contributors E-easy Call for participation: Experience needed to fix: Easy / not much labels Feb 8, 2022
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Feb 8, 2022
@EricCrosson
Copy link
Contributor

EricCrosson commented Feb 9, 2022

I ran into this a while back, was confused when I tried saving a read-only file. Everything looked good (or at least the same), there was no error (which probably deserves a separate issue) but it was confusing when I checked git status and found no modifications.

I only learned that I had no write permissions when I tried making the same edit in vim and saw the error on save.

@sudormrfbin
Copy link
Member

I ran into this a while back, was confused when I tried saving a read-only file. Everything looked good (or at least the same), there was no error (which probably deserves a separate issue) but it was confusing when I checked git status and found no modifications.

I only learned that I had no write permissions when I tried making the same edit in vim and saw the error on save.

Tracked in #1575.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants