Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon arm64 release #1647

Closed
chromer030 opened this issue Feb 11, 2022 · 7 comments · Fixed by #3137
Closed

Apple Silicon arm64 release #1647

chromer030 opened this issue Feb 11, 2022 · 7 comments · Fixed by #3137
Labels
A-packaging Area: Packaging and bundling C-enhancement Category: Improvements E-help-wanted Call for participation: Extra attention is needed

Comments

@chromer030
Copy link

Describe your feature request

Please provide binary for macOS arm64, likes provided for Linux arm64.
Thanks.

@chromer030 chromer030 added the C-enhancement Category: Improvements label Feb 11, 2022
@archseer archseer added the E-help-wanted Call for participation: Extra attention is needed label Feb 11, 2022
@archseer
Copy link
Member

I've tried but I couldn't get the CI build working, it requires cross-compilation since there's no M1 github action runners. Might be resolved once helix is available on homebrew.

If you or anyone can get a working CI configuration I'd be open to accept the change though.

@kirawi kirawi added the A-packaging Area: Packaging and bundling label Feb 11, 2022
@jdahm
Copy link
Contributor

jdahm commented Mar 5, 2022

As a datapoint, I get the following error when using the helix nix flake on my M1 Mac:

error: a 'aarch64-linux' with features {} is required to build '/nix/store/l4r33m9ys148295f3djjys1hf1vxpvap-crates-io-aho-corasick-0.7.18.drv', but I am a 'aarch64-darwin' with features {benchmark, big-parallel, nixos-test}
       … while realising the context of path '/nix/store/46bk939yfxqfpcr2z246pc8kgpynrnhm-nzkj99qdd3mcyasq7hgm1mc3ah43pk9l-source-crate2nix'

When I use the check devshell target in helix I get a different error, this time when compiling tree-sitter:

error: builder for '/nix/store/jr9w79v3nrik4np2ryhrjxvpqa60q2x7-rust_tree-sitter-0.20.4.drv' failed with exit code 1;
       > error occurred: Command "gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-arch" "arm64" "-I" "src" "-I" "include" "-Wall" "-Wextra" "-std=c99" "-Wno-unused-parameter" "-o" "/private/tmp/nix-build-rust_tree-sitter-0.20.4.drv-0/tree-sitter-0.20.4/target/build/tree-sitter.out/src/lib.o" "-c" "src/lib.c" with args "gcc" did not execute successfully (status code exit status: 1).

Will investigate further when I find time.

Other refs:

@Dreamacro
Copy link

https://www.macstadium.com/opensource Can this help in any way?

@the-mikedavis
Copy link
Member

We might be able to use that to run a custom github actions runner. It wasn't initially supported for a while (actions/runner@088caf5) but it looks like actions/runner got M1 support recently: actions/runner@d769477

@yvt
Copy link
Contributor

yvt commented Jun 23, 2022

I managed to get aarch64 CI builds working with cross compilation. Tests can't be run because Rosetta 2 doesn't work in the other way around, though.

@archseer
Copy link
Member

@yvt Would you mind opening up a PR? We can conditionally skip the test runs since it's tested on the regular build at least.

@yvt
Copy link
Contributor

yvt commented Jul 21, 2022

Would you mind opening up a PR?

Done in #3137

@yvt yvt mentioned this issue Jul 29, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling C-enhancement Category: Improvements E-help-wanted Call for participation: Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants