-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to not have newlines selectable #3076
Comments
I fear that this could make the behavior quite inconsistent and harder to follow if in some cases the newline was selected and in others not, causing weird side effects depending on what inputs the user performs. Though I can't say for sure, maybe this could work pretty smoothly? |
This gets even more inconsistent: if you place the cursor on an empty line, you're literally placing the cursor onto the EOL character. Disabling this would mean a bunch of workarounds for empty lines. |
If I understand #376 correctly, the cursor actually internally is between the |
#376 allows expressing ranges as positions between characters, but cursors in helix always have a width of 1. This is why pressing |
The current behavior is quite elegant when it comes to selections: you can treat newline like any other character so you can do things like Normally I would agree that behavior should be customizable but in this case I think it's out of scope: as archseer says, in order to make this configurable, we'd need to add a bunch of workarounds which would be pretty hacky. Ultimately this is a smaller but comparable problem as having an evil mode (vim bindings). Maintaining competing paradigms is a pain so it's out of scope |
When you say it like so for me it sounds like helix aims to be consistently bad, guys in #585 correctly point out that there is no point in looking at some thing called "kakoune", the point is to make a good editor and good editor should have a good design and intuitive UX. |
@adsick Thanks for the ping! You are being rude again, so I'm not going to respond. You are welcome to start a polite discussion next time. |
Kakoune used to treat the EOL specially, but changed this behavior during its development. |
by my personal standards there is nothing rude in my speech, it simply is my response to your "consistent" status quo where things make no sense to outsiders (but are "consistent" for some small % of users). In fact I'm trying to help helix be more accessible to people who know nothing about "kakoune" whatever it is (most people out there). If you care so much about correctness and politeness then I want to mention that your behavior in my regard is somewhat toxic too because it basically goes like so adsick and normies: hey, it bothers me, let's change/improve it! You of course can continue to do that and make your kakoune echo chamber prosper, but in reality it won't get much traction as others will simply switch to nvim/VScode where things just work well... normally After in all it maybe just me not getting all of those extremely useful and "comprehensive" features you put in helix (and behaviours that arise from them). take multiple cursors wrapping around string boundaries. I'm stubborn but say it once again "kakoune" doesn't necessarily means "good" (intuitive/productive/rich), people need something that is good, not something that is "kakoune" |
It is kinda funny being accused of rudeness seeing you basically rejecting improvements using the same arguments everytime - "kakoune" and "inconsistent" |
Actually, the point for us is to make an editor we enjoy using ourselves. In our opinions, helix is already a good editor and has good design and intuitive UX.
That's ok. Helix isn't trying to be everything for everyone. We're just working on editor we enjoy working on and designing it the way we like it. Disagreeing with our design choices is fine but we've been explicit that we have no desire to change some core design principles like following the select-then-act paradigm or treating newlines like characters. If you continue to disagree, you can...
But being "stubborn" and continuing to complain about our choices does nothing but antagonize us. |
Okay, okay I get it, thanks for your time spent. Started thinking of fork myself, but not quite sure if my development skills are enough for that. Anyway good luck doing what you're up to. |
@adsick I noticed that some of the user experience stuff that you have pointed out I have looked into quite a few of them in the past but haven't make them into reality yet, like I am more than happy if you send some pull requests to improve the current state of art, just tag me and I will help to look at them. But I will also appreciate if you can reword the way you comment, if you want others to listen to your opinions. The other way you could help if you are not experienced with development is to try out pull requests that involves keybindings and user experience changes, for example help me to review #2412, I always wanted some feedbacks. If you standards of rudeness are low it's fine, but the other maintainers standard may likely be high. Pro tip, remove all the words "you"/"your" from your comments, that will hugely reduce the rudeness others perceived. |
There already has been some discussion on newline characters being treated like any other in #585 and #2956. As this is a very frequent stumbling stone for me as well, I'd like to propose adding an option to treat newline characters special. With this new option set, Helix would:
x
, unless it's in between multiple lines that are selectedxd
to delete the whole lineReasoning:
The text was updated successfully, but these errors were encountered: