Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort diagnostics by gravity (error -> warning -> info) #3543

Closed
poliorcetics opened this issue Aug 25, 2022 · 2 comments · Fixed by #9647
Closed

Sort diagnostics by gravity (error -> warning -> info) #3543

poliorcetics opened this issue Aug 25, 2022 · 2 comments · Fixed by #9647
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@poliorcetics
Copy link
Contributor

Describe your feature request

When there are lots of warnings or infos in a project, the error diagnostics can be lost and hard to find in the diagnostic pickers.

They could be sorted by gravity to help go to the errors first.

@poliorcetics poliorcetics added the C-enhancement Category: Improvements label Aug 25, 2022
@the-mikedavis
Copy link
Member

We do this now for diagnostic icons in the gutter: #2827

I think it would be useful to have a way to sort the diagnostics picker by severity but I'm not sure we should sorting by severity by default. Sorting by location also seems like a reasonable default, or leaving it to whatever order the Language Server gives.

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Aug 27, 2022
@poliorcetics
Copy link
Contributor Author

To avoid changing anything in the sort there could be a marker that can be searched for in the view, lik [E] [W] and [I] maybe ? Files with collisions in those names will be very rare, and diagnostic text too (though here maybe it will collide a little more but that should be manageable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
3 participants