CTRL+K (kill_to_line_end) selects autocomplete option

[johalun]

Summary

When I go to insert mode on code that pops up the autocomplete list I can't do CTRL+K (kill_to_line_end), instead it selects an option from the autocomplete menu and inserts into the editor. On a comment for example where there's no autocomplete options, CTRL+K works as expected.

Reproduction Steps

I tried this:

1. cd helix # clone of helix repo
2. hx helix-core/src/diagnostic.rs
3. Put cursor on something that will autocomplete, for example on the i in usize
4. Go to insert mode
5. See the autocomplete menu popup with us completions like usize2x etc
6. Press CTRL+K to kill to end of line

I expected this to happen:
The characters after the cursor to be deleted

Instead, this happened:
usize is replaced with the last item in the autocomplete list usizex8

Helix log

Nothing relevant in the log

Platform

macOS

Terminal Emulator

iTerm2

Helix Version

helix 22.05 (06a5bca)

[the-mikedavis]

(Misclick sorry 😅)

[the-mikedavis]

Can you reproduce this on master? It looks like you're on a branch based on #2377

[philipgiuliani]

I can reproduce this more or less on master (59b886c). Found out about CTRL+k today but everytime before I use it the LSP pops up with the suggestions and CTRL+k inserts the first suggestion from the list.

Tested in elixir files using elixir-ls.

1. Switching to insert mode:
   
2. Clicking CTRL+k
   

[DylanBulfin]

I'm new to the codebase so I could be wrong, but it seems that whenever the completion menu pops up, it takes precedence in handling certain key commands such as C-k (kill to end of line) ,C-j (insert newline), tab, etc. The workaround is to press C-c to exit the completion menu first. (check the menu file for input handling info).

[DylanBulfin]

There was a similar issue with pickers at one point, where C-k navigation overwrote the intended behavior of C-k killing to end of line in the prompt. This was addressed by #1792, made a new PR #5070 to try and resolve this for the completion menu as well

[the-mikedavis]

Fixed in #5070