Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify markup.strikethrough in themes #5595

Closed
CptPotato opened this issue Jan 19, 2023 · 1 comment · Fixed by #5619
Closed

Specify markup.strikethrough in themes #5595

CptPotato opened this issue Jan 19, 2023 · 1 comment · Fixed by #5619
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@CptPotato
Copy link
Contributor

Currently markdown text for strike through isn't visualized in any way.

It looks like everything is already in place for this to work. Only the themes need updating, by adding the missing theme key:

"markup.strikethrough" = { modifiers = ["crossed_out"] }

The result looks like this:
image

This seems like a rather trivial change. I can take a look at updating the themes if you want.

@CptPotato CptPotato added the C-enhancement Category: Improvements label Jan 19, 2023
@CptPotato
Copy link
Contributor Author

Strike through in doc comments doesn't work with this change, yet, similar to bold and italic. If I understand correctly, it requires changes to this match:

for event in parser {
match event {

@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants