Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to set publishDiagnostic/tagSupport for pyright #8443

Closed
maximyurevich opened this issue Oct 2, 2023 · 2 comments
Closed

how to set publishDiagnostic/tagSupport for pyright #8443

maximyurevich opened this issue Oct 2, 2023 · 2 comments

Comments

@maximyurevich
Copy link

maximyurevich commented Oct 2, 2023

how to set publishDiagnostic/tagSupport capability for pyright, like neovim
neovim/nvim-lspconfig#726 (comment)
neovim/nvim-lspconfig#726 (comment)

@pascalkuthe
Copy link
Member

helix does not support diagnostic tags and does not indicate as such in its capabilities so this doesn't apply to us.

We could enable support for them in the future but then there would be no way to disable it (although if we do support them we would only support them properly by rendering striketrough/greyed out text). I don't think we want to allow user to customize tags in their confugation. It is not possible to update capabilities without restarting the server and LSP capabilities are really not meant for user configuration (the actual configuration can be updated with DidChangeConfiguration)

@maximyurevich
Copy link
Author

maximyurevich commented Oct 2, 2023

helix does not support diagnostic tags and does not indicate as such in its capabilities so this doesn't apply to us.

We could enable support for them in the future but then there would be no way to disable it (although if we do support them we would only support them properly by rendering striketrough/greyed out text). I don't think we want to allow user to customize tags in their confugation. It is not possible to update capabilities without restarting the server and LSP capabilities are really not meant for user configuration (the actual configuration can be updated with DidChangeConfiguration)

Better not add with no way to disable it, I wanted to turn them off, like in neovim, but it turns out there is simply no support

@helix-editor helix-editor locked and limited conversation to collaborators Oct 2, 2023
@the-mikedavis the-mikedavis converted this issue into discussion #8444 Oct 2, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants