Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong syntax for XML comment #9842

Closed
ndtoan96 opened this issue Mar 10, 2024 · 1 comment
Closed

Wrong syntax for XML comment #9842

ndtoan96 opened this issue Mar 10, 2024 · 1 comment
Labels
C-bug Category: This is a bug

Comments

@ndtoan96
Copy link

Summary

Helix is currently using C style comment for XML. But that's wrong. XML comment should be like this: <!--Your comment-->

Reproduction Steps

  1. open an XML document
  2. press Ctrl+c to comment a line

Helix log

No response

Platform

Windows

Terminal Emulator

wezterm 20240203-110809-5046fc22

Installation Method

winget

Helix Version

helix 23.10 (f6021dd)
@ndtoan96 ndtoan96 added the C-bug Category: This is a bug label Mar 10, 2024
@kirawi
Copy link
Member

kirawi commented Mar 10, 2024

Fixed on master #4718

@kirawi kirawi closed this as completed Mar 10, 2024
@kirawi kirawi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndtoan96 @kirawi