Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid comment token in PKGBUILD files #9942

Closed
hnorkowski opened this issue Mar 20, 2024 · 2 comments · Fixed by #9943
Closed

Invalid comment token in PKGBUILD files #9942

hnorkowski opened this issue Mar 20, 2024 · 2 comments · Fixed by #9943
Labels
C-bug Category: This is a bug

Comments

@hnorkowski
Copy link
Contributor

Summary

When using the comment command (Ctrl+c for me) in PKGBUILD // is used as comment token. In previous versions the correct token # was used.

Could be related to #9909

Reproduction Steps

I tried this:

  1. hx PKGBUILD
  2. comment a line

I expected this to happen:
Line gets prefixed with #

Instead, this happened:
Line gets prefixed with //

Helix log

No response

Platform

Linux

Terminal Emulator

alacritty

Installation Method

source

Helix Version

bcf7b26
@hnorkowski hnorkowski added the C-bug Category: This is a bug label Mar 20, 2024
@pascalkuthe
Copy link
Member

That filetype simply doesn't have a comment tokens defined. Adding one in the languages.toml is trivial. Feel free to send a PR

@hnorkowski hnorkowski mentioned this issue Mar 20, 2024
Merged
@c0rydoras
Copy link
Contributor

I completely forgot about adding the comment token 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(languages): specify correct comment-token for PKGBUILD files hnorkowski/helix
3 participants
@hnorkowski @pascalkuthe @c0rydoras