Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request.pathDecodedLength is always zero. #7

Closed
jshanab opened this issue May 2, 2020 · 1 comment
Closed

Request.pathDecodedLength is always zero. #7

jshanab opened this issue May 2, 2020 · 1 comment

Comments

@jshanab
Copy link

jshanab commented May 2, 2020

Not yet sure what the differnce is between path and decoded path but in my case they have the same values but the pathDecodedLength is always 0.
hellerf added a commit that referenced this issue May 3, 2020
@hellerf
https://github.com/hellerf/EmbeddableWebServer/issues/7
6e53a89 
Indeed - the pathDecodedLength field was never set. Now URLDecode will return the decoded length if desired. I added some unit tests for URLDecode since it seems like a function which should be at least minimally unit tested.
@hellerf
Copy link
Owner

hellerf commented May 3, 2020

Thanks for reporting! Very embarrassing. This is now fixed on master.

@hellerf hellerf closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellerf @jshanab