Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo maintainers ? #138

Open
jgournet opened this issue Jun 16, 2023 · 8 comments
Open

Repo maintainers ? #138

jgournet opened this issue Jun 16, 2023 · 8 comments

Comments

@jgournet
Copy link

Hi,

Is this project still maintained ?
Last commit was a year ago, and there are several PR waiting to be merged.
@crhuber maybe ?

Cheers,

@martin31821
Copy link

martin31821 commented Jun 16, 2023

Hi

I've recently forked this repo and brought it up-to-date and published a docker image here.
I'd be willing to merge PR's although the tests are broken there.

Find it here: https://github.com/deinstapel/eks-rolling-update

Cheers

@Jasper-Ben
Copy link

👋 @jgournet looking at the commit history and since all the previous contributors don't work at hello-fresh any more, I think it is safe to say, that this repo is unmaintained.

As @martin31821 already pointed out, we have a fork that works well with current EKS (we use it in production). If there is no update from the maintainers in this issue within the next days, we will create a hard fork, which we will maintain.

Right now there is still missing documentation (e.g. required k8s RBAC permissions for node draining) in our fork, which we will add within the next couple of days.

@jgournet
Copy link
Author

jgournet commented Jul 6, 2023

@Jasper-Ben / @martin31821 :
I guess the lack of answer is pretty clear :)
Let me know if you go ahead and create a hard fork + merge all the pending PRs

in any case: thank you

@Jasper-Ben
Copy link

@jgournet I guess so 😉
We will go ahead with the hardfork and the README cleanup. Regarding the open PRs, I am not quite sure which of them are still relevant after the changes @martin31821 has done. Are you interested in any particular PR?

@jgournet
Copy link
Author

jgournet commented Jul 9, 2023

@Jasper-Ben : thanks !
and yes, the PR I needed was: #130 :)

@Jasper-Ben
Copy link

👋 @jgournet

I haven't forgotten about you, just was a busy week and I didn't manage to move this any further. We should manage to get this rolling next week 🙂

@Jasper-Ben
Copy link

https://github.com/deinstapel/eks-rolling-update was converted into a hardfork with its own issues and PRs

@Jasper-Ben
Copy link

👋 @jgournet,

just letting you know, that I will recreate the work (again). Thought I need to create a new repo over a fork for enabling issues and PRs. turns out that it is just a setting in the forked repo 🤦‍♂️. Unfortunately there is no option to mark a repo as fork after the fact, so recreating for visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants