Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting changed files is broken in v1.1.0 #61

Closed
aabouzaid opened this issue Nov 8, 2020 · 5 comments
Closed

Detecting changed files is broken in v1.1.0 #61

aabouzaid opened this issue Nov 8, 2020 · 5 comments

Comments

@aabouzaid
Copy link

Hello,

because of the latest change in v1.1.0, now charts_dir doesn't work with "." (current working directory)

local depth=$(( $(tr "/" "\n" <<< "$charts_dir" | wc -l) + 1 ))

This expression cannot be less than 2 that's why no changes detected in the current working directory.

$ echo $(( $(tr "/" "\n" <<< "." | wc -l) + 1 )) 
2

The + 1 should be removed.

@ohdearaugustin
Copy link

I can confirm that issue.

@ravikrs
Copy link

ravikrs commented Nov 22, 2020

I also faced this issue after upgrading version to 1.1.0
Downgraded the chart-releaser-action version to 1.0.0 for now

@madchap
Copy link

madchap commented Feb 24, 2021

Still seems to be present in 1.2.0.

@monotek
Copy link

monotek commented Mar 7, 2021

@unguiculus
Copy link
Member

Fixed in #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants