fix chart finder when dir is more than 1 dir deep #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr.sh
Outdated
| fi | ||
|
|
||
| cut -d '/' -f "$fields" <<< "$changed_files" | uniq | filter_charts | ||
| find "$charts_dir" -maxdepth 1 -type d -not -path "$charts_dir" |filter_charts |
There was a problem hiding this comment.
I don't think this will work as expected as it does not take into consideration the changed_files
There was a problem hiding this comment.
Thanks for pointing that out. I forgot to do the comparison against that var here; not sure how I missed that.
isaaguilar
force-pushed
the
chart-finder-fix
branch
from
62c9272
to
7773ce6
Compare
Signed-off-by: isaaguilar <[email protected]>
isaaguilar
force-pushed
the
chart-finder-fix
branch
from
7773ce6
to
8d99886
Compare
|
Closing this PR for the much more elegant solution in #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes chart_dir when charts are deeper than 1 dir from root