[stable/external-dns] Addded a parameter for supporting --aws-assume-…

[enis]

…role flag in external-dns

Signed-off-by: Enis Soztutar [email protected]

What this PR does / why we need it:

external-dns supports a command line flag --aws-assume-role implemented via kubernetes-sigs/external-dns#524, but the helm chart does not support this. This jira adds supports for the command line option.

Special notes for your reviewer:

There is also a related roleArn parameter, but that works a bit differently since it sets the role to assume using aws default credentials. roleArn requires setting secret and access keys. Sending the --aws-assume-role is different since it will work with instance profile creds.

@jvassev may want to take a look.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md

[k8s-ci-robot]

Hi @enis. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enis]

/assign @viglesiasce

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[enis]

/assign @prydonius

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[davidkarlsen]

/ok-to-test
/assign

[davidkarlsen]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, enis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [davidkarlsen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment