Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding grid_width and grid_length to room and grid_length to exit [Quest export] #15

Open
Selsynn opened this issue Aug 11, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@Selsynn
Copy link
Contributor

Selsynn commented Aug 11, 2018

Two parameters that are not taken into account in the export to quest.
Like the other issue, I can do it, if you think it's interesting. Else, I want to know why you're not interested.

@henck
Copy link
Owner

henck commented Aug 11, 2018

By all means, add this. I do think that when we're going to make changes to the .json save format and code export, we'll need some sort of test suite so that would be a priority.

@Selsynn
Copy link
Contributor Author

Selsynn commented Aug 11, 2018

For now, I don't need to change the json savefile.
For the issue #12 I should need it, but i will have it for later, time to get to know the project

@henck henck added the enhancement New feature or request label Aug 13, 2019
@henck
Copy link
Owner

henck commented Aug 26, 2019

There is now support for Quest's grid_width and grid_length. Trizbort takes the room size as drawn by the user, then calculates the grid width/length by dividing the room size by the default room size, rounded down.

That is, an ordinary room has a grid width and grid length of 1. If you resize a room to be twice as big, it will have a grid width and length of 2. If you make it 3.5 times as big, its grid width and length will be 3.

I understand how grid_length for exits works, but I am not sure how Trizbort should implement that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants