Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Support REDIS_URL #27

Open
dcramer opened this issue Feb 10, 2015 · 5 comments
Open

Support REDIS_URL #27

dcramer opened this issue Feb 10, 2015 · 5 comments

Comments

@dcramer
Copy link

dcramer commented Feb 10, 2015

Flask-Redis appears to utilize this setting. It should work with both RedisCloud and RedisToGo as both seem semi-supported.

@singingwolfboy
Copy link
Contributor

@dcramer Seems like a good idea. Would you like to make a pull request? (Sorry for the long delay in responded -- I didn't realize that I wasn't getting GitHub notifications for this repository!)

@brainix
Copy link

brainix commented Jun 26, 2015

I just submitted a pull request to support REDIS_URL (which takes care of Heroku's new Redis add-on). My pull request also supports environment variables for all of the other Redis providers. :-)

@singingwolfboy
Copy link
Contributor

@brainix: I just saw this comment after searching for issues related to #31. Looks like the pull request you made is #29, which has no description and never got reviewed. The changes in that pull request look great to me, though. Would you like to open a new pull request with those changes, and tag me to review it?

@brainix
Copy link

brainix commented Mar 12, 2016

@singingwolfboy: Thanks for the comment. Sure, I'll open up a new PR this weekend!

@singingwolfboy
Copy link
Contributor

Great! Sorry for totally missing your first PR. My bad. 😞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants