Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .ruby-version #346

Open
3 tasks
schneems opened this issue Nov 6, 2024 · 0 comments
Open
3 tasks

Support .ruby-version #346

schneems opened this issue Nov 6, 2024 · 0 comments

Comments

@schneems
Copy link
Contributor

schneems commented Nov 6, 2024

In rails/rails#51089 the .ruby-version file is being adopted by Rails in Rails 8. They're also dropping support for integrating it with bundler by default. To that end we can add support for the .ruby-version file but it's unclear which should "win" when there's a conflict.

Here's an example implementation of the .python-version heroku/buildpacks-python#272

The logic should be like this:

  • If there is a Ruby version in Gemfile.lock, use it. Otherwise use .ruby-version otherwise Error.
  • If there's a ruby version in both the Gemfile.lock and the .ruby-version error if they disagree

Known tasks:

  • Add support for .ruby-version file as described above
  • Research and document syntax of most common tools for .ruby-version
  • Add JVM detection to also look at the .ruby-version file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant