Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "No change in requirements detected, installing from cache" message is sometimes shown incorrectly #1678

Closed
edmorley opened this issue Oct 30, 2024 · 0 comments · Fixed by #1679
Assignees
Labels

Comments

@edmorley
Copy link
Member

Currently if the cache was discarded due to a reason other than the requirements.txt file changing and the app uses pip + has a requirements.txt file, then the No change in requirements detected, installing from cache message is shown here incorrectly:

output::step "No change in requirements detected, installing from cache"

This can be seen in the TODOs in these tests:

# TODO: The output shouldn't say "installing from cache", since it's not.
expect(clean_output(app.output)).to include(<<~OUTPUT)
remote: -----> Python app detected
remote: -----> Using Python 3.13 specified in .python-version
remote: -----> Python version has changed from #{LATEST_PYTHON_3_9} to #{LATEST_PYTHON_3_13}, clearing cache
remote: -----> No change in requirements detected, installing from cache

# TODO: The requirements output shouldn't say "installing from cache", since it's not.
expect(clean_output(app.output)).to include(<<~OUTPUT)
remote: -----> Python app detected
remote: -----> No Python version was specified. Using the same version as the last build: Python 3.12.3
remote: To use a different version, see: https://devcenter.heroku.com/articles/python-runtimes
remote:
remote: ! Warning: A Python security update is available!
remote: !
remote: ! Upgrade as soon as possible to: Python #{LATEST_PYTHON_3_12}
remote: ! See: https://devcenter.heroku.com/articles/python-runtimes
remote:
remote: -----> Stack has changed from heroku-22 to heroku-24, clearing cache
remote: -----> No change in requirements detected, installing from cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant