Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a more fully featured maven buildpack example #11

Closed
hone opened this issue Mar 18, 2021 · 2 comments
Closed

a more fully featured maven buildpack example #11

hone opened this issue Mar 18, 2021 · 2 comments
Labels

Comments

@hone
Copy link
Member

hone commented Mar 18, 2021

No description provided.

@hone hone added this to the 0.2.0 milestone Mar 18, 2021
@edmorley edmorley removed this from the 0.2.0 milestone Oct 8, 2021
@Malax
Copy link
Member

Malax commented Jun 20, 2022

I don't think we need this anymore. We have a Ruby example that demonstrates the the usage of libcnb for a concrete language buildpack. The example would not demonstrate additional parts of the libcnb API beyond what the Ruby example does. Not sure where the value-add is here.

On the other hand, this is more code we need to maintain and not all maintainers have the context required to do so efficiently.

Thoughts @heroku/languages?

@edmorley
Copy link
Member

edmorley commented Jun 20, 2022

I agree, lets close this out.

Longer term, once more of Heroku's languages (a) have CNBs, (b) are using libcnb.rs for those CNBs, we can perhaps add links to the real language buildpacks from examples/README.md etc as a "here are some more advanced real buildpacks you can learn from".

I also think we should perhaps reconsider having the Ruby example, given (a) it's broken (#398), (b) it's always going to be in that weird area of trying to be a simple example, but also not trying to skip best practices, with people then thinking that's an actual optimised Ruby implementation when it's not. Perhaps we need some other simple examples on each libcnb topic instead? We can still have some ~real examples, but say do something simpler like a JQ or AWS Cli buildpack for them?

@edmorley edmorley closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants