You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The test uses call_test_fixture_service rather than something more realistic like ureq
The web server isn't compliant with the HTTP spec (so attempts to use ureq to make a request to it fail)
The app is unnecessarily complicated - it does not need to accept a posted value and invert it - replying with a fixed string to a GET would do (eg just using a Ruby stdlib HTTP server)
It uses a hardcoded sleep, rather than something like:
// Retries needed since the server takes a moment to start up.
letmut attempts_remaining = 5;
let response = loop{
let response = ureq::get(&url).call();
if response.is_ok() || attempts_remaining == 0{
break response;
}
attempts_remaining -= 1;
thread::sleep(Duration::from_secs(1));
}
.unwrap();
It uses Ruby 2.7, so has to use the heroku/buildpacks:20 builder image (rather than the heroku/builder:22 used by other tests), which slows down CI as it means another builder image has to be pulled.
The text was updated successfully, but these errors were encountered:
The test has several issues:
call_test_fixture_service
rather than something more realistic likeureq
ureq
to make a request to it fail)libcnb.rs/libcnb-test/tests/integration_test.rs
Lines 77 to 87 in 2a75bb6
heroku/buildpacks:20
builder image (rather than theheroku/builder:22
used by other tests), which slows down CI as it means another builder image has to be pulled.The text was updated successfully, but these errors were encountered: