Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"print preview demo" in Printing #190

Closed
GoogleCodeExporter opened this issue May 10, 2015 · 7 comments
Closed

"print preview demo" in Printing #190

GoogleCodeExporter opened this issue May 10, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

Issue with PrintDialog and PrintDirect.

PrintDialog:
The title is default filled in as: "Print Preview Demo". This seems to be hard 
coded. It should be blank so it shows the "Enter map title here."

PrintDirect:
It gives the map the title of "Print Preview Demo". Should probably be blank by 
default. Option to get it from a variable set by the implementer might be good 
workaround.

Original issue reported on code.google.com by [email protected] on 10 Apr 2013 at 12:36

@GoogleCodeExporter
Copy link
Author

This should be a simple one to fix; can we stick it in 0.73?

Original comment by [email protected] on 10 Apr 2013 at 12:37

  • Added labels: Milestone-Release0.73

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 10 Apr 2013 at 3:41

@GoogleCodeExporter
Copy link
Author


This will show a message to enter something
{type:"printdialog", options:{url:'/print-servlet/prd', mapTitle: ''}}

This will show a blank line
{type:"printdialog", options:{url:'/print-servlet/prd', mapTitle: ' '}}

Original comment by [email protected] on 11 Apr 2013 at 10:09

@GoogleCodeExporter
Copy link
Author

Good work around for the printDialog issue.

It does solve the second "PrintDirect" point above. Might be worth sticking in 
the example.

Original comment by [email protected] on 11 Apr 2013 at 10:12

@GoogleCodeExporter
Copy link
Author

I removed some hardcoded "Print Preview Demo" defaults. Also removed A3 
Portrait from the yaml temporarily as it is broken. 

The situation should be as follows, for config:
- mapTitle : null (no need for '' or ' ')
* no MapTitle in PrintDirect, "Enter map title here." in PrintDialog
- mapTitle: 'My Title"
* 'My Title" as title in PrintDirect and prefilled in PrintDialog title field

Thre is quite some flexibiilty in config, also how to name your variables in 
.yaml. This has been some work by Wolfram.

http://lib.heron-mc.org/heron/latest/examples/printdialog and the Config.js:
http://lib.heron-mc.org/heron/latest/examples/printdialog/Config.js
(may need to shift-reload)

if  found ok we can close this issue and put fix in 0.73.

Original comment by [email protected] on 12 Apr 2013 at 3:25

@GoogleCodeExporter
Copy link
Author

Ok to close this one?

Original comment by [email protected] on 6 May 2013 at 1:21

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Looks good to me.

Original comment by [email protected] on 7 May 2013 at 9:26

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant