Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in example notebook #10

Open
moffat opened this issue Sep 9, 2017 · 0 comments
Open

Issues in example notebook #10

moffat opened this issue Sep 9, 2017 · 0 comments

Comments

@moffat
Copy link

moffat commented Sep 9, 2017

Hi Rob,

I've been exploring octant (nice job!) and it looks like you're working on a new version, so the comments below might be bad timing, but I found a few issues trying to run the example notebook:

z = octant.roms.nc_depths(nc, 'rho')[tidx]

failed because in roms.py you have:

self.s = depths.get_srho(self.N)

and it looks like it should be

self.s = get_srho(self.N)

here and in the rest of this function.

I got past this, but tripped up in

s50 = octant.tools.isoslice(salt,z,-50);

it looks you're moving those functions from tools to slice, so I tried

s50 = octant.slice.isoslice(salt,z,-50);

but that failed with:

isoslice(var, prop, isoval, axis, masking)
27 prop = prop.swapaxes(0, axis)
28 prop=prop-isoval
---> 29 sz = shape(var)
30 var = var.reshape(sz[0],-1)
31 prop = prop.reshape(sz[0],-1)

NameError: global name 'shape' is not defined`

again, if you're in the middle of refactoring this, never mind, but I'd appreciate any pointers.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant