You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been exploring octant (nice job!) and it looks like you're working on a new version, so the comments below might be bad timing, but I found a few issues trying to run the example notebook:
z = octant.roms.nc_depths(nc, 'rho')[tidx]
failed because in roms.py you have:
self.s = depths.get_srho(self.N)
and it looks like it should be
self.s = get_srho(self.N)
here and in the rest of this function.
I got past this, but tripped up in
s50 = octant.tools.isoslice(salt,z,-50);
it looks you're moving those functions from tools to slice, so I tried
Hi Rob,
I've been exploring octant (nice job!) and it looks like you're working on a new version, so the comments below might be bad timing, but I found a few issues trying to run the example notebook:
z = octant.roms.nc_depths(nc, 'rho')[tidx]
failed because in roms.py you have:
self.s = depths.get_srho(self.N)
and it looks like it should be
self.s = get_srho(self.N)
here and in the rest of this function.
I got past this, but tripped up in
s50 = octant.tools.isoslice(salt,z,-50);
it looks you're moving those functions from tools to slice, so I tried
s50 = octant.slice.isoslice(salt,z,-50);
but that failed with:
again, if you're in the middle of refactoring this, never mind, but I'd appreciate any pointers.
Thanks.
The text was updated successfully, but these errors were encountered: